Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Use gcal functions + Deploy gcal.fly.dev #31 #35

Merged
merged 11 commits into from
May 16, 2023
Merged

PR: Use gcal functions + Deploy gcal.fly.dev #31 #35

merged 11 commits into from
May 16, 2023

Conversation

nelsonic
Copy link
Member

@nelsonic nelsonic commented May 15, 2023 •
edited
Loading

This PR:

  • removes the private (untested or indirectly tested) Google Calendar functions
    in favour of using github.com/dwyl/gcal 👌
  • renames the Fly.io App from dwyl-calendar to gcal for brevity

@nelsonic nelsonic added enhancement New feature or enhancement of existing functionality elixir Pull requests that update Elixir code chore a tedious but necessary task often paying technical debt in-progress An issue or pull request that is being worked on by the assigned person labels May 15, 2023
@nelsonic nelsonic self-assigned this May 15, 2023
@nelsonic nelsonic added this to More ToDo ThanCanEver Be Done in Nelson's List via automation May 15, 2023
@codecov
Copy link

codecov bot commented May 16, 2023 •
edited
Loading

Codecov Report

Merging #35 (f2d5067) into main (ffe6f3f) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #35   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         7    -1     
  Lines           82        59   -23     
=========================================
- Hits            82        59   -23
Impacted Files Coverage Δ
lib/cal_web/controllers/google_auth_controller.ex 100.00% <ø> (ø)
lib/cal_web/live/app_live.ex 100.00% <100.00%> (ø)
lib/cal_web/live/app_live_html.ex 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nelsonic nelsonic requested a review from LuchoTurtle May 16, 2023 09:12
@nelsonic nelsonic moved this from More ToDo ThanCanEver Be Done to Awaiting Feedback/Review in Nelson's List May 16, 2023
@nelsonic nelsonic added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels May 16, 2023
@nelsonic
Copy link
Member Author

@LuchoTurtle please take a quick look at this and if it all makes sense, merge. 🙏

@nelsonic nelsonic changed the title PR: Use gcal functions + Deploy cal.fly.dev #31 PR: Use gcal functions + Deploy gcal.fly.dev #31 May 16, 2023
LuchoTurtle
LuchoTurtle approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@LuchoTurtle LuchoTurtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👌

@LuchoTurtle LuchoTurtle merged commit 4aaa3e8 into main May 16, 2023
3 checks passed
Nelson's List automation moved this from Awaiting Feedback/Review to Done May 16, 2023
@LuchoTurtle LuchoTurtle deleted the use-gcal-functions-issue-#31 branch May 16, 2023 09:41
@nelsonic
Copy link
Member Author

Thanks @LuchoTurtle 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuchoTurtle LuchoTurtle LuchoTurtle approved these changes

Assignees

@nelsonic nelsonic

Labels
awaiting-review An issue or pull request that needs to be reviewed chore a tedious but necessary task often paying technical debt elixir Pull requests that update Elixir code enhancement New feature or enhancement of existing functionality
Projects
Nelson's List
  
Done
dwyl app kanban
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nelsonic @LuchoTurtle